Skip to content

fixed issue "Forgot password form should not available while customer is logged in." #18901#18903

Closed
webkul-ratnesh wants to merge 3 commits intomagento:2.2-developfrom
webkul-ratnesh:ratnesh-18901
Closed

fixed issue "Forgot password form should not available while customer is logged in." #18901#18903
webkul-ratnesh wants to merge 3 commits intomagento:2.2-developfrom
webkul-ratnesh:ratnesh-18901

Conversation

@webkul-ratnesh
Copy link
Contributor

@webkul-ratnesh webkul-ratnesh commented Oct 28, 2018

Description (*)

By applying this fix magento is unable to open forgot password page after customer login

Fixed Issues (if relevant)

  1. Forgot password form should not available while customer is logged in. #18901: Forgot password form should not available while customer is logged in.

Manual testing scenarios (*)

  1. Goto forgot password link
  2. Then goto customer login page and do successful login.
  3. It should not redirect customer to forgot password page.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 28, 2018

Hi @webkul-ratnesh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@webkul-ratnesh webkul-ratnesh changed the title Ratnesh 18901 fixed issue "Forgot password form should not available while customer is logged in." #18901 Oct 28, 2018
@dnsv dnsv assigned dnsv and unassigned dnsv Oct 28, 2018
@VladimirZaets VladimirZaets self-assigned this Oct 28, 2018
@webkul-ratnesh
Copy link
Contributor Author

webkul-ratnesh commented Oct 29, 2018

#SQUASHTOBERFEST

@webkul-ratnesh webkul-ratnesh added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 29, 2018
@swnsma
Copy link
Contributor

swnsma commented Nov 26, 2018

Hi @webkul-ratnesh,

Look like issue already has been fixed in 2.2-develop with #19089.
I will close this PR.
Thank you for your time.

@swnsma swnsma closed this Nov 26, 2018
@webkul-ratnesh
Copy link
Contributor Author

webkul-ratnesh commented Nov 26, 2018

@swnsma I did not understand what just happen, I requested PR 29 days ago, but other PR accepted with same fix that requested 20 days ago.
Any ways thanks for the information, might be i am missing something.

@swnsma
Copy link
Contributor

swnsma commented Nov 26, 2018

@webkul-ratnesh,

Looks like there is something wrong with this pull request. Please check changes.

I think it has lead to confusion and, as result, that your pull request has stuck.

I apologize that this has happened with you.
I can advice to check changes in pull request, to be sure that true changes are available for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swnsma swnsma Awaiting requested review from swnsma

Assignees

@VladimirZaets VladimirZaets

Labels

Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@webkul-ratnesh @magento-engcom-team @swnsma @dnsv @VladimirZaets